Skip to content
Snippets Groups Projects

Rename MTS related variables, fix parameters checking and documentation

Merged Rename MTS related variables, fix parameters checking and documentation
bossen/VVCSoftware_VTM:clean57 into master
1 unresolved thread
Merged Frank Bossen requested to merge bossen/VVCSoftware_VTM:clean57 into master
1 unresolved thread

Merge request reports

Merge request pipeline #6753 passed

Stage: build

Merge request pipeline passed for c2448717

Merged by Xiang LiXiang Li 3 years ago (Jan 17, 2022 5:05pm UTC)

Merge details

  • Changes merged into with 57d0c31f.
  • Did not delete the source branch.

Pipeline #6756 passed

Stage: build

Pipeline passed for 57d0c31f on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Xiang Li
    Xiang Li @XiangLi
    Maintainer

    Code wise, lgtm

  • Frank Bossen marked this merge request as draft

    marked this merge request as draft

  • Frank Bossen added 1 commit

    added 1 commit

    • c2448717 - Revert validation change and add MTS=4 mode

    Compare with previous version

  • Xiang Li resolved all threads

    resolved all threads

  • Xiang Li approved this merge request

    approved this merge request

  • Frank Bossen marked this merge request as ready

    marked this merge request as ready

  • Xiang Li mentioned in commit 57d0c31f

    mentioned in commit 57d0c31f

  • Xiang Li merged

    merged

  • Karsten Suehring
    Karsten Suehring @ksuehring started a thread on the diff
    • doc/software-manual.tex
    3129 3129 \Default{false} &
    3130 3130 Enables or disables the fast encoding of Bi-prediction with CU-level Weights (BCW).
    3131 3131 \\
    3132
    3133 \Option{MTS} &
    3134 %\ShortOption{\None} &
    3135 \Default{0} &
    3136 Enables explicit mutiple transform set (MTS).
    3137 0: disable,
    3138 1: enable explicit intra MTS,
    3139 2: enable implicit intra and explicit inter MTS,
    3140 3: enable explicit intra and explicit inter MTS,
    3141 4: enable implicit intra MTS.
    3142 \\
    3143
    3144 \Option{MTSImplicit} &
    • Karsten Suehring
      Karsten Suehring @ksuehring
      Owner

      Should this be marked as deprecated if it's equivalent to MTS=4?

    • Frank Bossen
      Frank Bossen @bossen
      Author Maintainer

      Would make sense to do so. Remind me how we mark things as deprecated.

    • Karsten Suehring
      Karsten Suehring @ksuehring
      Owner

      Looking at !2062 (merged) it seems for conformance window parameters only the text for the parameter description was set to "Depcrecated alias for...". Documentation was changed to the new parameters directly when they were renamed. I think in this case we could add a deprecation note to documentation and parameter description. We could even print a warning, if the parameter is enabled because it's read into a different variable.

    • Please register or sign in to reply
    Please register or sign in to reply